Skip to content

[Workspace] Restore artifact root configuration validation for workspaces#20544

Merged
B-Step62 merged 6 commits intomlflow:orgnization-supportfrom
mprahl:readd-check
Feb 7, 2026
Merged

[Workspace] Restore artifact root configuration validation for workspaces#20544
B-Step62 merged 6 commits intomlflow:orgnization-supportfrom
mprahl:readd-check

Conversation

@mprahl
Copy link
Collaborator

@mprahl mprahl commented Feb 3, 2026

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Re-add preflight checks that validate the default artifact root is not configured with reserved path segments:

  1. Reject roots ending with 'workspaces' (e.g., /artifacts/workspaces)
  2. Reject roots already scoped under 'workspaces/' prefix

These validations catch admin misconfiguration without blocking the disable/re-enable workspace workflow. The previous removal in #20477 was too aggressive - only the database query for existing experiments needed to be removed (that check blocked re-enabling workspaces after experiments had been moved to the default workspace).

This also addresses issues after the rebase.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20544/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20544/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20544/merge

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. labels Feb 3, 2026
@B-Step62 B-Step62 force-pushed the orgnization-support branch from aca57a2 to 29f8002 Compare February 4, 2026 00:22
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the last commit, looks good! Can you rebase the PR?

Re-add preflight checks that validate the default artifact root is not
configured with reserved path segments:

1. Reject roots ending with 'workspaces' (e.g., /artifacts/workspaces)
2. Reject roots already scoped under 'workspaces/<name>' prefix

These validations catch admin misconfiguration without blocking the
disable/re-enable workspace workflow. The previous removal in mlflow#20477
was too aggressive - only the database query for existing experiments
needed to be removed (that check blocked re-enabling workspaces after
experiments had been moved to the default workspace).

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Documentation preview for 501eebe is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@B-Step62 B-Step62 merged commit b8789b9 into mlflow:orgnization-support Feb 7, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants