Skip to content

Fix typo in PromoteModelButton#19820

Merged
harupy merged 1 commit intomlflow:masterfrom
Abhiii47:fix/typo-pomote
Jan 8, 2026
Merged

Fix typo in PromoteModelButton#19820
harupy merged 1 commit intomlflow:masterfrom
Abhiii47:fix/typo-pomote

Conversation

@Abhiii47
Copy link
Contributor

@Abhiii47 Abhiii47 commented Jan 8, 2026 •
edited
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19820/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19820/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19820/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

@Abhiii47 Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. v3.8.2 and removed area/tracking Tracking service, tracking client APIs, autologging labels Jan 8, 2026
harupy
harupy approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026 •
edited
Loading

Documentation preview for 7b9f34e is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@Abhiii47 Abhiii47 requested a review from harupy January 8, 2026 13:05
@harupy
Copy link
Member

harupy commented Jan 8, 2026

@Abhiii47 can you run yarn i18n in mlflow/server/js?

@Abhiii47
Copy link
Contributor Author

Abhiii47 commented Jan 8, 2026

@Abhiii47 can you run yarn i18n in mlflow/server/js?
@harupy yeah can try it

@Abhiii47
Copy link
Contributor Author

Abhiii47 commented Jan 8, 2026

i ran yarn i18n as requested, which updated (en.json )with the new message ID generated from the corrected description.
However, I noticed this change generated a new ID (Qv7cZx) and orphaned the old ID (+RYBrq) across all other language strings, effectively breaking their translations..

@harupy
Copy link
Member

harupy commented Jan 8, 2026

@Abhiii47 Can you commit and push the change? Other language files can be ignored

@Abhiii47
Copy link
Contributor Author

Abhiii47 commented Jan 8, 2026

Can you commit and push the change? Other language files can be ignored

sure

@harupy
Copy link
Member

harupy commented Jan 8, 2026

Lets fix the DCO check

@Abhiii47
Copy link
Contributor Author

Abhiii47 commented Jan 8, 2026

Member

fixed the DCO checks

@Abhiii47
fix: typo in PromoteModelButton and sync translation keys
7b9f34e 
Signed-off-by: abhijeet <abhijeetkadu85@gmail.com>
@harupy harupy enabled auto-merge January 8, 2026 15:44
@harupy harupy added this pull request to the merge queue Jan 8, 2026
Merged via the queue into mlflow:master with commit 9d4bbdd Jan 8, 2026
50 checks passed
@Abhiii47
Copy link
Contributor Author

Abhiii47 commented Jan 8, 2026

thank u so much for the help @harupy

@Abhiii47 Abhiii47 deleted the fix/typo-pomote branch January 8, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harupy harupy Awaiting requested review from harupy

Assignees

@harupy harupy

Labels

area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. v3.8.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abhiii47 @harupy