QueryTraceMetrics: add handler and update rest store#19448
Merged
serena-ruan merged 3 commits intotrace-metricsfrom Dec 18, 2025
Merged
QueryTraceMetrics: add handler and update rest store#19448serena-ruan merged 3 commits intotrace-metricsfrom
serena-ruan merged 3 commits intotrace-metricsfrom
Conversation
Contributor
|
Documentation preview for af64049 is available at: More info
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for querying trace metrics through a new QueryTraceMetrics API endpoint. The implementation includes REST API handler, store method, and entity serialization/deserialization support.
- Adds
query_trace_metricsmethod to RestStore for executing trace metrics queries - Implements
_query_trace_metricshandler to process API requests with validation - Extends entity classes with
from_protoandto_protomethods for MetricViewType, MetricAggregation, and MetricDataPoint
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mlflow/entities/trace_metrics.py | Adds bidirectional proto conversion methods: from_proto() for MetricViewType and MetricAggregation, and to_proto() for MetricDataPoint |
| mlflow/store/tracking/rest_store.py | Implements query_trace_metrics() method that constructs requests, calls the endpoint, and returns paginated results |
| mlflow/server/handlers.py | Adds _query_trace_metrics() handler with request validation schema and response construction, registers it in HANDLERS dict |
| tests/entities/test_trace_metrics.py | Adds test coverage for new proto conversion methods |
| tests/store/tracking/test_rest_store.py | Tests REST store query method including endpoint calls and response parsing |
| tests/server/test_handlers.py | Tests handler with both populated and empty results, including pagination |
| tests/tracking/test_rest_tracking.py | Integration test that creates traces and queries metrics with aggregations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5a6e16e to
af64049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Add handler for QueryTraceMetrics and update rest_store for handling it.
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.