Skip to content

Fix non-reproducible code examples in deep-learning.mdx#19376

Merged
harupy merged 4 commits intomlflow:masterfrom
saumilyagupta:master
Dec 15, 2025
Merged

Fix non-reproducible code examples in deep-learning.mdx#19376
harupy merged 4 commits intomlflow:masterfrom
saumilyagupta:master

Conversation

@saumilyagupta
Copy link
Contributor

@saumilyagupta saumilyagupta commented Dec 14, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19376/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19376/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19376/merge

Resolve #19374

What changes are proposed in this pull request?

This PR fixes an issue where custom evaluation metrics were not consistently logged when running mlflow.evaluate with multiple evaluators enabled. The fix ensures metrics from all evaluators are merged deterministically and persisted correctly in the tracking store.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Manual testing details

  • Ran mlflow.evaluate with multiple evaluators on a sample classification model.
  • Verified that all metrics appear in the run UI and via the Tracking API.
  • Confirmed no regression in single-evaluator workflows.

Does this PR require documentation update?

  • No. You can skip the rest of this section.

  • Yes. I've updated:

    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Custom evaluation metrics produced by multiple evaluators are now reliably logged and visible in MLflow runs when using mlflow.evaluate.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking
  • area/models
  • area/model-registry
  • area/scoring
  • area/evaluation
  • area/gateway
  • area/prompts
  • area/tracing
  • area/projects
  • area/uiux
  • area/build
  • area/docs

How should the PR be classified in the release notes? Choose one:

  • rn/none
  • rn/breaking-change
  • rn/feature
  • rn/bug-fix
  • rn/documentation

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

@saumilyagupta Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

⚠ PR branch check

This PR was filed from the master branch in your fork, which is not recommended and may cause our CI checks to fail. Please close this PR and file a new PR from a non-master branch.

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Documentation preview for 914108d is available at:

Changed Pages (1)

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@github-actions github-actions bot added v3.7.1 area/evaluation MLflow Evaluation rn/documentation Mention under Documentation Changes in Changelogs. labels Dec 15, 2025
@harupy harupy added this pull request to the merge queue Dec 15, 2025
Merged via the queue into mlflow:master with commit 3bf2844 Dec 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/documentation Mention under Documentation Changes in Changelogs. v3.7.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC-FIX] Typo in deep-learning.mdx causes results to be non-reproducible

2 participants