Skip to content

Use db_uri fixture in test_rest_store_webhooks.py to skip database migration#19369

Merged
harupy merged 3 commits intomasterfrom
copilot/use-db-uri-fixture-for-tests
Dec 13, 2025
Merged

Use db_uri fixture in test_rest_store_webhooks.py to skip database migration#19369
harupy merged 3 commits intomasterfrom
copilot/use-db-uri-fixture-for-tests

Conversation

Copy link
Contributor

Copilot AI commented Dec 13, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

The store fixture in tests/store/model_registry/test_rest_store_webhooks.py was creating a new SQLite database from scratch for each test, triggering expensive migrations. Modified it to use the db_uri fixture, which provides a pre-migrated database that's copied per test.

Changes:

  • Added db_uri: str parameter to store fixture
  • Changed backend_uri from f"sqlite:///{tmp_path / 'mlflow.db'}" to db_uri

This follows the pattern established in test_model_registry.py and test_rest_tracking.py.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

All 12 existing tests in the file pass without modification.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Use db_uri fixture in tests/store/model_registry/test_rest_store_webhooks.py to skip db migration


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@harupy harupy marked this pull request as ready for review December 13, 2025 10:34
Copilot AI review requested due to automatic review settings December 13, 2025 10:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ooks.py

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Use db_uri fixture to skip db migration in tests Use db_uri fixture in test_rest_store_webhooks.py to skip database migration Dec 13, 2025
Copilot AI requested a review from harupy December 13, 2025 10:41
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy changed the title Use db_uri fixture in test_rest_store_webhooks.py to skip database migration Use db_uri fixture in test_rest_store_webhooks.py to skip database migration Dec 13, 2025
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 13, 2025
@harupy harupy enabled auto-merge December 13, 2025 11:07
@harupy harupy added this pull request to the merge queue Dec 13, 2025
Merged via the queue into master with commit e35e11a Dec 13, 2025
47 of 50 checks passed
@harupy harupy deleted the copilot/use-db-uri-fixture-for-tests branch December 13, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants