Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…est_scoring_server.py Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace pyfunc_serve_and_score_model with score_model_in_process
Replace pyfunc_serve_and_score_model with score_model_in_process in test_scoring_server.py
Dec 13, 2025
pyfunc_serve_and_score_model with score_model_in_process in test_scoring_server.py
harupy
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Migrated 29 test invocations (20 test functions) in
tests/pyfunc/test_scoring_server.pyfrompyfunc_serve_and_score_modeltoscore_model_in_processfor faster execution. The subprocess-based approach spawns a full HTTP server per test; in-process testing via FastAPI TestClient eliminates this overhead while maintaining identical coverage.Changes:
pyfunc_serve_and_score_modelwithscore_model_in_process, removedextra_argsparameters (subprocess-only), removed unused importscore_model_in_processto handle DataFrame inputs (CSV/JSON conversion) matchingRestEndpoint.invokebehaviorNot migrated:
test_scoring_server_client: Tests actual server process lifecycletest_get_cmd: Tests CLI argument generationHow is this PR tested?
All 29 migrated tests pass. The unmigrated
test_scoring_server_clienthas unrelated network connectivity issues.Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
prefix.dev/usr/bin/conda conda env create -n mlflow-649524f40dede2c3c64e928921acb05cbc8b270e --file /tmp/pytest-of-REDACTED/pytest-4/test_scoring_server_client0/model/conda.yaml e d -n 10(dns block)/usr/bin/conda conda env create -n mlflow-649524f40dede2c3c64e928921acb05cbc8b270e --file /tmp/pytest-of-REDACTED/pytest-4/test_scoring_server_client0/model/conda.yaml ndor/bin/uname(dns block)/usr/bin/conda conda env create -n mlflow-649524f40dede2c3c64e928921acb05cbc8b270e --file /tmp/pytest-of-REDACTED/pytest-4/test_scoring_server_client0/model/conda.yaml .19/x64/git(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.