Skip to content

Speed up test_gateway_sql_store.py by using db_uri fixture#19366

Merged
harupy merged 2 commits intomasterfrom
copilot/use-db-uri-fixture
Dec 13, 2025
Merged

Speed up test_gateway_sql_store.py by using db_uri fixture#19366
harupy merged 2 commits intomasterfrom
copilot/use-db-uri-fixture

Conversation

Copy link
Contributor

Copilot AI commented Dec 13, 2025

What changes are proposed in this pull request?

The test_gateway_sql_store.py test suite was slow because each test created a fresh database and ran migrations. This PR adopts the db_uri fixture pattern from test_sqlalchemy_store.py, which provides a pre-migrated database copy.

Changes:

  • Modified store fixture to accept db_uri parameter instead of creating database from scratch
  • Added _cleanup_database() function to clear gateway tables when using persistent database (MLFLOW_TRACKING_URI)
  • Imported gateway SQL models for cleanup operations

Performance:

  • Before: 38.37s (0.665s avg per test)
  • After: 10.90s (0.180s avg per test)
  • 3.5x speedup (72% reduction)

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

All 57 existing tests pass with identical behavior.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

tests/store/tracking/test_gateway_sql_store.py is slow. Use db_uri fixture


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@harupy harupy marked this pull request as ready for review December 13, 2025 09:22
Copilot AI review requested due to automatic review settings December 13, 2025 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve performance of SQL store tests using db_uri fixture Speed up test_gateway_sql_store.py by using db_uri fixture Dec 13, 2025
Copilot AI requested a review from harupy December 13, 2025 09:37
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 13, 2025
@harupy harupy enabled auto-merge December 13, 2025 10:08
@harupy harupy added this pull request to the merge queue Dec 13, 2025
Merged via the queue into master with commit c0ad774 Dec 13, 2025
55 of 56 checks passed
@harupy harupy deleted the copilot/use-db-uri-fixture branch December 13, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants