Remove redundant tracking_uri fixtures from test files#19294
Merged
harupy merged 1 commit intomlflow:masterfrom Dec 9, 2025
Merged
Remove redundant tracking_uri fixtures from test files#19294harupy merged 1 commit intomlflow:masterfrom
harupy merged 1 commit intomlflow:masterfrom
Conversation
After mlflow#19258, tracking_uri_mock in tests/conftest.py now uses db_uri and is autouse by default. This makes per-file tracking_uri fixtures redundant. Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant per-file tracking_uri fixtures from test files after the tracking_uri_mock fixture in tests/conftest.py was made autouse by default in #19258. The changes eliminate code duplication while preserving test functionality.
- Removes 5 redundant
tracking_urifixtures from test files - Removes 2 unused imports of
_use_tracking_uri - Maintains correct behavior for both regular tests and
IS_TRACING_SDK_ONLYscenarios
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tracking/test_tracking.py | Removes redundant tracking_uri fixture that was superseded by the autouse fixture in conftest.py |
| tests/tracking/test_log_image.py | Removes redundant tracking_uri fixture and unused _use_tracking_uri import |
| tests/tracking/fluent/test_fluent.py | Removes redundant tracking_uri fixture that duplicated conftest.py functionality |
| tests/tracing/test_fluent.py | Removes redundant tracking_uri fixture with IS_TRACING_SDK_ONLY handling, now covered by conftest.py's conditional autouse |
| tests/artifacts/test_artifacts.py | Removes redundant tracking_uri fixture and unused _use_tracking_uri import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#19258
What changes are proposed in this pull request?
After #19258,
tracking_uri_mockintests/conftest.pynow usesdb_uriand isautouseby default. This makes per-filetracking_urifixtures redundant, so this PR removes them.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionShould this PR be included in the next patch release?
🤖 Generated with Claude Code