Skip to content

Fix UC to UC copying regression#19280

Merged
BenWilson2 merged 3 commits intomlflow:masterfrom
BenWilson2:fix-uc-to-uc
Dec 10, 2025
Merged

Fix UC to UC copying regression#19280
BenWilson2 merged 3 commits intomlflow:masterfrom
BenWilson2:fix-uc-to-uc

Conversation

@BenWilson2
Copy link
Member

@BenWilson2 BenWilson2 commented Dec 8, 2025 •
edited by github-actions bot
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19280/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19280/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19280/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Fixes a regression accidentally introduced in #17458 that made model_id required in the abstract implementation, forcing the UC registry store to fail for the previously working path of copying models across workspaces (which was entirely functional prior to 3.4.0).

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@BenWilson2
Fix UC copying regression
c4368c9 
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Copilot AI review requested due to automatic review settings December 8, 2025 22:32
@github-actions github-actions bot added v3.7.1 area/model-registry Model registry, model registry APIs, and the fluent client calls for model registry rn/bug-fix Mention under Bug Fixes in Changelogs. labels Dec 8, 2025
Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression introduced in PR #17458 that broke cross-workspace UC model copying. The regression made model_id effectively required by not handling cases where the logged model lookup fails due to the model being in a different, inaccessible workspace.

Key Changes:

  • Added exception handling to gracefully handle RESOURCE_DOES_NOT_EXIST errors when retrieving logged models by ID
  • Added debug logging to document the cross-workspace scenario
  • Added comprehensive test coverage for the new error handling logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
mlflow/store/_unity_catalog/registry/rest_store.py Added try-catch block in _get_logged_model_from_model_id to handle RESOURCE_DOES_NOT_EXIST exceptions and return None instead of failing, enabling cross-workspace model copying
tests/store/_unity_catalog/model_registry/test_unity_catalog_rest_store.py Added three test cases covering success, None input, and resource-not-found scenarios for _get_logged_model_from_model_id

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025 •
edited
Loading

Documentation preview for 4ac9de9 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@BenWilson2
feedback
d09c48d 
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@BenWilson2 BenWilson2 added the team-review Trigger a team review request label Dec 10, 2025
serena-ruan
serena-ruan approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we add a test checking create_model_version is not blocked if the model is not found?

@BenWilson2
Copy link
Member Author

BenWilson2 commented Dec 10, 2025

LGTM! Could we add a test checking create_model_version is not blocked if the model is not found?

Great idea @serena-ruan - verifying the behavior that existed prior to the change made in 3.4.0 addresses the original test coverage gap that allowed the regression to happen in the first place. Thanks for calling this out :D I'll add that test prior to merging. Appreciate it!

@BenWilson2
add fantastic idea from Serena
4ac9de9 
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@BenWilson2 BenWilson2 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into mlflow:master with commit 312edd5 Dec 10, 2025
47 checks passed
@BenWilson2 BenWilson2 deleted the fix-uc-to-uc branch December 10, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@serena-ruan serena-ruan serena-ruan approved these changes

@B-Step62 B-Step62 Awaiting requested review from B-Step62

@daniellok-db daniellok-db Awaiting requested review from daniellok-db

@harupy harupy Awaiting requested review from harupy

@kevin-lyn kevin-lyn Awaiting requested review from kevin-lyn

@TomeHirata TomeHirata Awaiting requested review from TomeHirata

@WeichenXu123 WeichenXu123 Awaiting requested review from WeichenXu123

@xq-yin xq-yin Awaiting requested review from xq-yin

Assignees

@serena-ruan serena-ruan

Labels

area/model-registry Model registry, model registry APIs, and the fluent client calls for model registry rn/bug-fix Mention under Bug Fixes in Changelogs. team-review Trigger a team review request v3.7.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWilson2 @serena-ruan