Skip to content

Convert auto assign to cron job to check all PRs#19270

Merged
serena-ruan merged 8 commits intomasterfrom
fix_auto_assign
Dec 9, 2025
Merged

Convert auto assign to cron job to check all PRs#19270
serena-ruan merged 8 commits intomasterfrom
fix_auto_assign

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Dec 8, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19270/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19270/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19270/merge

Related Issues/PRs

Previous implementation of the auto-assign job doesn't work on PRs filed from forked repos due to secrets permission issue (e.g. https://github.com/mlflow/mlflow/actions/runs/20017852341/job/57398826571#step:2:24) As a result, convert it to a cron job runs automatically to check the PRs updated in the last 4 hours and add assignees.

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Copilot AI review requested due to automatic review settings December 8, 2025 07:53
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR converts the auto-assign workflow from an event-driven approach to a scheduled cron job to work around GitHub Actions secrets permission issues when PRs are filed from forked repositories. The workflow now runs every 3 hours to scan recently updated PRs and automatically assign maintainers who have commented.

Key Changes:

  • Changed trigger from issue_comment/pull_request_review_comment events to a cron schedule running every 3 hours
  • Implemented batch processing logic to scan all PRs updated in the last 4 hours and check for maintainer comments
  • Added permissions for contents: read and issues: write in addition to existing pull-requests: write

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan
Copy link
Collaborator Author

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan serena-ruan changed the title [Test] Convert auto assign to cron job to check all PRs Convert auto assign to cron job to check all PRs Dec 9, 2025
@serena-ruan serena-ruan merged commit cb3d56d into master Dec 9, 2025
43 of 46 checks passed
@serena-ruan serena-ruan deleted the fix_auto_assign branch December 9, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants