Add a targeted review selection action#19261
Merged
BenWilson2 merged 3 commits intomlflow:masterfrom Dec 10, 2025
Merged
Conversation
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions workflow that automatically assigns 2 randomly selected maintainers to review pull requests when the maintainer-review label is applied. The workflow uses the Fisher-Yates shuffle algorithm for unbiased random selection and filters out the PR author and maintainers who have already approved.
Key changes:
- Added a new workflow triggered by the
maintainer-reviewlabel on pull requests - Implements fair random selection using Fisher-Yates shuffle algorithm instead of biased sorting methods
- Filters eligible reviewers by excluding the PR author and those who have already approved
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harupy
reviewed
Dec 8, 2025
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
harupy
reviewed
Dec 9, 2025
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
Member
There was a problem hiding this comment.
let's add a concurrency field to make sure this workflow has a single run?
Member
Author
There was a problem hiding this comment.
Great call out @harupy - super critical that we don't get multiple assignees here!
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Add an action that randomly selects 2 maintainers for a review for targeted ownership reviews.
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.