Use tempfile context manager in db_uri fixture to avoid polluting tmp_path#19255
Merged
Use tempfile context manager in db_uri fixture to avoid polluting tmp_path#19255
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…leanup - Changed from using tmp_path to tempfile.NamedTemporaryFile - Uses context manager for automatic cleanup - Avoids polluting tmp_path directory used by other tests - Simplified code by removing manual cleanup logic Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update db_uri fixture to use tempfile for SQLite
Use tempfile context manager in db_uri fixture to avoid polluting tmp_path
Dec 6, 2025
harupy
reviewed
Dec 7, 2025
…ermission error - Switched from tempfile.NamedTemporaryFile to tempfile.TemporaryDirectory - Fixes PermissionError on Windows when copying to an open file handle - Creates db file inside temporary directory instead of using temp file directly - Automatic cleanup still handled by context manager Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
approved these changes
Dec 7, 2025
…ctory cleanup errors Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
The
db_urifixture was creating SQLite database files in thetmp_pathdirectory, which could interfere with tests that usetmp_pathand expect a clean directory.Changes:
tmp_path / "mlflow.db"withtempfile.TemporaryDirectory()yieldfor automatic cleanuptmp_pathparameter dependency from the fixtureNote: Initially used
NamedTemporaryFile, but switched toTemporaryDirectoryto fix a WindowsPermissionErrorthat occurred when trying to copy data to an open file handle.How is this PR tested?
Verified with existing tests in
tests/store/model_registry/,tests/store/tracking/, andtests/artifacts/.Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.