Skip to content

Fix auto-assign workflow to avoid assigning PR owner as assignee#19235

Merged
serena-ruan merged 2 commits intomasterfrom
copilot/fix-assignee-assignment
Dec 5, 2025
Merged

Fix auto-assign workflow to avoid assigning PR owner as assignee#19235
serena-ruan merged 2 commits intomasterfrom
copilot/fix-assignee-assignment

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

Related Issues/PRs

#19203

What changes are proposed in this pull request?

The auto-assign workflow from #19203 assigns maintainers as assignees when they comment on PRs, but doesn't skip when the commenter is the PR owner.

Added conditions to skip assignment when commenter equals PR author:

  • issue_comment events: github.event.comment.user.login != github.event.issue.user.login
  • pull_request_review_comment events: github.event.comment.user.login != github.event.pull_request.user.login

How is this PR tested?

  • Manual tests

Validated YAML syntax and workflow condition logic.

Does this PR require documentation update?

  • No. You can skip the rest of this section.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/build: Build and test infrastructure for MLflow

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Can you fix #19203 to avoid assigning the PR owner as assignee?


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 5, 2025
Co-authored-by: serena-ruan <82044803+serena-ruan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix automatic PR owner assignment to assignee Fix auto-assign workflow to avoid assigning PR owner as assignee Dec 5, 2025
Copilot AI requested a review from serena-ruan December 5, 2025 06:09
@serena-ruan serena-ruan marked this pull request as ready for review December 5, 2025 06:11
Copilot AI review requested due to automatic review settings December 5, 2025 06:11
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 5, 2025
@serena-ruan serena-ruan closed this Dec 5, 2025
@serena-ruan serena-ruan reopened this Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the auto-assign workflow to prevent maintainers from being automatically assigned to their own PRs when they comment on them. The fix adds conditions to check whether the commenter is the PR owner before triggering the assignment.

  • Added condition checks to skip auto-assignment when the commenter is the PR owner
  • Updated the workflow comment to reflect the new behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@serena-ruan serena-ruan marked this pull request as draft December 5, 2025 06:14
@serena-ruan serena-ruan marked this pull request as ready for review December 5, 2025 06:14
@serena-ruan serena-ruan added this pull request to the merge queue Dec 5, 2025
Merged via the queue into master with commit 5c9e844 Dec 5, 2025
90 of 166 checks passed
@serena-ruan serena-ruan deleted the copilot/fix-assignee-assignment branch December 5, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants