Skip to content

Add rounded corners to video elements in documentation#19231

Merged
harupy merged 4 commits intomasterfrom
copilot/add-rounded-corners-videos
Dec 5, 2025
Merged

Add rounded corners to video elements in documentation#19231
harupy merged 4 commits intomasterfrom
copilot/add-rounded-corners-videos

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Adds border-radius: 12px to video elements in documentation for visual consistency with other media elements (e.g., hero images).

Changes:

  • Added video styling section in /docs/src/css/custom.css
  • Applied 12px border radius to all <video> elements

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Verified:

  • CSS syntax passes prettier formatting
  • Pre-commit hooks pass
  • No conflicts with existing styles

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Video elements in documentation now have rounded corners for improved visual consistency.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Add the following to add rounded corners on videos

// docs/src/css/custom.css

video {
  border-radius: 12px;
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 5, 2025
@harupy harupy marked this pull request as ready for review December 5, 2025 02:15
Copilot AI review requested due to automatic review settings December 5, 2025 02:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add rounded corners to video elements Add rounded corners to video elements in documentation Dec 5, 2025
Copilot AI requested a review from harupy December 5, 2025 02:23
@github-actions github-actions bot added v3.7.0 area/docs Documentation issues rn/documentation Mention under Documentation Changes in Changelogs. labels Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Documentation preview for 3999215 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Member

@kevin-lyn kevin-lyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@B-Step62
Copy link
Collaborator

B-Step62 commented Dec 5, 2025

Can we copy the other styles from the ImageBox too?

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy
Copy link
Member

harupy commented Dec 5, 2025

@B-Step62

Can we copy the other styles from the ImageBox too?

Copied a couple styles applicable to videos. Let me know if there are any missing styles.

@B-Step62
Copy link
Collaborator

B-Step62 commented Dec 5, 2025

Thanks, yea they look great!

@harupy harupy enabled auto-merge December 5, 2025 04:48
@harupy harupy disabled auto-merge December 5, 2025 05:26
@harupy harupy merged commit 177f047 into master Dec 5, 2025
43 of 46 checks passed
@harupy harupy deleted the copilot/add-rounded-corners-videos branch December 5, 2025 05:27
@github-actions github-actions bot added v3.7.1 and removed v3.7.0 labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation issues rn/documentation Mention under Documentation Changes in Changelogs. v3.7.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants