Skip to content

Add pre-commit hook to flag mlflow ui and suggest mlflow server#19210

Merged
harupy merged 5 commits intomasterfrom
copilot/add-pre-commit-hook-mlflow
Dec 4, 2025
Merged

Add pre-commit hook to flag mlflow ui and suggest mlflow server#19210
harupy merged 5 commits intomasterfrom
copilot/add-pre-commit-hook-mlflow

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Added a pre-commit hook that flags usage of mlflow ui and suggests mlflow server instead, as mlflow ui is deprecated.

Implementation:

  • Added check-mlflow-ui hook to .pre-commit-config.yaml with inline bash logic using bin/rg
  • Added types: [text] to filter out binary files
  • Added exclusions for:
    • .pre-commit-config.yaml (contains the pattern in the hook itself)
    • Historical files: CHANGELOG.md, docs/api_reference/source/R-api.rst
    • R package files: mlflow/R/mlflow/*
    • Test and example data: tests/test_cli.py, examples/llms/RAG/*.{json,csv}
    • Implementation file: mlflow/cli/__init__.py (contains the aliasing logic)

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Manually verified:

  • Hook blocks commits containing mlflow ui in new files
  • Hook allows commits with mlflow server
  • All excluded files are correctly skipped
  • All existing pre-commit hooks continue to pass

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@harupy harupy marked this pull request as ready for review December 4, 2025 10:45
Copilot AI review requested due to automatic review settings December 4, 2025 10:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 3 commits December 4, 2025 10:53
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add pre-commit hook to flag mlflow ui usage Add pre-commit hook to flag mlflow ui and suggest mlflow server Dec 4, 2025
Copilot AI requested a review from harupy December 4, 2025 11:05
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 4, 2025
- Remove separate dev/check-mlflow-ui.sh script
- Inline the hook logic directly in .pre-commit-config.yaml
- Add types: [text] to filter out binary files
- Format exclude pattern with (?x) verbose regex for readability

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy force-pushed the copilot/add-pre-commit-hook-mlflow branch from 9656bae to ee95ced Compare December 4, 2025 11:25
@harupy harupy added this pull request to the merge queue Dec 4, 2025
Merged via the queue into master with commit aa89097 Dec 4, 2025
43 of 45 checks passed
@harupy harupy deleted the copilot/add-pre-commit-hook-mlflow branch December 4, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants