Skip to content

Add python.instructions.md for Copilot code review#19202

Merged
harupy merged 1 commit intomlflow:masterfrom
harupy:add-python-instructions-md
Dec 5, 2025
Merged

Add python.instructions.md for Copilot code review#19202
harupy merged 1 commit intomlflow:masterfrom
harupy:add-python-instructions-md

Conversation

@harupy
Copy link
Member

@harupy harupy commented Dec 4, 2025

Related Issues/PRs

N/A

What changes are proposed in this pull request?

Add .github/instructions/python.instructions.md to provide GitHub Copilot with Python code review guidelines. This file references dev/guides/python.md for style conventions.

Reference: https://github.blog/ai-and-ml/unlocking-the-full-power-of-copilot-code-review-master-your-instructions-files/

How is this PR tested?

  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/build: Build and test infrastructure for MLflow

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings December 4, 2025 03:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

@harupy Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds GitHub Copilot code review instructions for Python files by creating a new instruction file that references existing Python style conventions.

  • Creates .github/instructions/python.instructions.md with frontmatter configuration to apply to all Python files
  • References the existing Python style guide at dev/guides/python.md

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 4, 2025
@harupy harupy added the team-review Trigger a team review request label Dec 4, 2025
@harupy harupy changed the title Add python.instructions.md for Copilot code review Add python.instructions.md for Copilot code review Dec 4, 2025
@harupy harupy requested a review from Copilot December 4, 2025 03:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member Author

@harupy harupy Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted github/awesome-copilot#456 to check if this really works.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy force-pushed the add-python-instructions-md branch from 199e8bc to 4f11490 Compare December 5, 2025 02:56
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy merged commit acf05da into mlflow:master Dec 5, 2025
23 of 45 checks passed
@harupy harupy deleted the add-python-instructions-md branch December 5, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. team-review Trigger a team review request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants