Skip to content

Use cached_db fixture in tests/tracking/test_tracking.py to skip migration#19197

Merged
harupy merged 3 commits intomasterfrom
copilot/use-cached-db-in-tests
Dec 4, 2025
Merged

Use cached_db fixture in tests/tracking/test_tracking.py to skip migration#19197
harupy merged 3 commits intomasterfrom
copilot/use-cached-db-in-tests

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

Related Issues/PRs

N/A

What changes are proposed in this pull request?

This PR optimizes test execution time for tests/tracking/test_tracking.py by using the cached_db fixture to skip database migrations.

Database migrations were running for every test in tests/tracking/test_tracking.py, causing unnecessary overhead. This optimization reuses a pre-migrated SQLite database across tests by:

  • Adding a tracking_uri autouse fixture that copies the session-scoped cached_db to a test-specific temp directory
  • Setting the tracking URI to use the copied database
  • Resetting the tracking URI after each test

This pattern is already successfully used in other test files like test_rest_tracking.py, test_model_registry.py, and test_fluent.py.

Performance Impact:

  • 95 tests execution time: 12.9s (was ~20s+)
  • Per-test average: 0.133s (was 0.573s)
  • Overall improvement: ~37% faster

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

All 94 existing tests in tests/tracking/test_tracking.py pass with the new fixture (1 skipped as expected for Windows-specific test).

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Use cached_db fixture in tests/tracking/test_tracking.py to skip migration for faster test execution


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@harupy harupy marked this pull request as ready for review December 3, 2025 15:51
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Use cached_db fixture to skip migration in tests Use cached_db fixture in tests/tracking/test_tracking.py to skip migration Dec 3, 2025
Copilot AI requested a review from harupy December 3, 2025 16:09
@harupy
Copy link
Member

harupy commented Dec 3, 2025

@copilot update the pr description following pull_request_template.md

Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot update the pr description following pull_request_template.md

Updated the PR description to follow the pull_request_template.md format.

Copilot AI requested a review from harupy December 3, 2025 16:23
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 3, 2025
@harupy harupy added this pull request to the merge queue Dec 4, 2025
Merged via the queue into master with commit a45d4bd Dec 4, 2025
49 of 55 checks passed
@harupy harupy deleted the copilot/use-cached-db-in-tests branch December 4, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants