Skip to content

Use cached_db in tests/tracking/test_client.py for faster test execution#19196

Merged
harupy merged 4 commits intomasterfrom
copilot/use-cached-db-for-tests
Dec 3, 2025
Merged

Use cached_db in tests/tracking/test_client.py for faster test execution#19196
harupy merged 4 commits intomasterfrom
copilot/use-cached-db-for-tests

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Optimizes test execution in tests/tracking/test_client.py by using the cached_db fixture pattern already employed in other test files. Instead of running database migrations for each SQLAlchemy test, copies a pre-initialized cached database.

Changes:

  • Modified tracking_uri and registry_uri fixtures to accept cached_db parameter
  • SQLAlchemy backend now copies cached database instead of creating new instances
  • Simplified SQLite URI construction to use f"sqlite:///{db_path}" format for cross-platform compatibility
  • Removed unused monkeypatch parameter from tracking_uri
  • Fixed variable naming inconsistency in registry_uri
  • Removed unused sys import

Performance:

  • SQLAlchemy fixture setup: 0.61s → 0.04s (93% faster)
  • SQLAlchemy fixture teardown: 1.46s → 0.66s (55% faster)

How is this PR tested?

  • Existing unit/integration tests (185 tests pass)
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Use cached_db in tests/tracking/test_client.py for faster test execution


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@harupy harupy marked this pull request as ready for review December 3, 2025 14:49
Copilot AI and others added 2 commits December 3, 2025 14:59
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
… variable naming

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Use cached_db in test_client for faster execution Use cached_db in tests/tracking/test_client.py for faster test execution Dec 3, 2025
Copilot AI requested a review from harupy December 3, 2025 15:09
Use simpler f"sqlite:///{db_path}" format instead of platform-specific logic for better cross-platform compatibility. This approach is consistent with other test files using cached_db.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy December 3, 2025 15:18
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Dec 3, 2025
@harupy harupy enabled auto-merge December 3, 2025 15:50
@harupy harupy added this pull request to the merge queue Dec 3, 2025
Merged via the queue into master with commit 7d9a9a2 Dec 3, 2025
47 of 49 checks passed
@harupy harupy deleted the copilot/use-cached-db-for-tests branch December 3, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants