Cache database in tests/tracking/fluent/test_fluent.py to speed up tests on Windows#19161
Merged
harupy merged 2 commits intomlflow:masterfrom Dec 3, 2025
Merged
Conversation
…tests on Windows On Windows, db migration is very slow (~8 seconds per test). This change caches the SQLite database at the module level and copies it for each test, reducing the migration overhead and speeding up test execution. This is the same optimization applied in mlflow#19158 for `tests/tracing/test_fluent.py`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
|
Please use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#19158
What changes are proposed in this pull request?
On Windows, db migration is very slow (~8 seconds per test). This change caches the SQLite database at the module level and copies it for each test, reducing the migration overhead and speeding up test execution.
This is the same optimization applied in #19158 for
tests/tracing/test_fluent.py.Results
Before (without caching)
After (with caching)
Summary
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionShould this PR be included in the next patch release?