Fix router issue in TracesUI page#19044
Merged
daniellok-db merged 2 commits intomlflow:masterfrom Nov 26, 2025
Merged
Conversation
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
Contributor
|
Documentation preview for 702dd44 is available at: More info
|
mlflow/server/js/src/app.tsx
Outdated
| <QueryClientProvider client={queryClient}> | ||
| <MlflowRouter isDarkTheme={isDarkTheme} setIsDarkTheme={setIsDarkTheme} /> | ||
| </QueryClientProvider> | ||
| <DarkThemeProvider isDarkTheme={isDarkTheme} setIsDarkTheme={setIsDarkTheme}> |
Collaborator
There was a problem hiding this comment.
this is a minor nit but i see we're duplicating the isDarkTheme param with DesignSystemProvider. Could we remove it from this one and extract isDarkTheme like:
const { theme } = useDesignSystemTheme();
const isDarkTheme = theme.isDarkTheme;
Suggested change
| <DarkThemeProvider isDarkTheme={isDarkTheme} setIsDarkTheme={setIsDarkTheme}> | |
| <DarkThemeProvider setIsDarkTheme={setIsDarkTheme}> |
| const [showSidebar, setShowSidebar] = useState(true); | ||
| const { theme } = useDesignSystemTheme(); | ||
| const { experimentId } = useParams(); | ||
| const { isDarkTheme, setIsDarkTheme } = useDarkThemeContext(); |
Collaborator
There was a problem hiding this comment.
see below comment
Suggested change
| const { isDarkTheme, setIsDarkTheme } = useDarkThemeContext(); | |
| const { setIsDarkTheme } = useDarkThemeContext(); | |
| const isDarkTheme = theme.isDarkTheme; |
daniellok-db
approved these changes
Nov 26, 2025
Collaborator
daniellok-db
left a comment
There was a problem hiding this comment.
lgtm after nits addressed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Fix router issue in TracesUI page when switching between dark theme and light theme
What changes are proposed in this pull request?
Fix router issue in TracesUI page when switching between dark theme and light theme
How is this PR tested?
Before:
Screen.Recording.2025-11-26.at.9.20.25.AM.mov
After:
https://github.com/user-attachments/assets/1e6502cd-411c-494b-84a2-714355006462
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.