Skip to content

UI: Request TraceInfo and Trace Assessments from a relative API path #19032

Merged
serena-ruan merged 2 commits intomlflow:masterfrom
kbolashev:assessments-reverse-proxy
Nov 27, 2025
Merged

UI: Request TraceInfo and Trace Assessments from a relative API path #19032
serena-ruan merged 2 commits intomlflow:masterfrom
kbolashev:assessments-reverse-proxy

Conversation

@kbolashev
Copy link
Contributor

@kbolashev kbolashev commented Nov 25, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19032/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19032/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19032/merge

Related Issues/PRs

#19031

What changes are proposed in this pull request?

Change API calls happening in mlflow/server/js/src/shared/web-shared/model-trace-explorer/api.ts to happen from relative path, and not absolute.
This way, if MLflow is being proxied under http://localhost:8080/mlflow, the call to e.g. get the trace info gets fired to:

http://localhost:8080/mlflow/ajax-api/3.0/mlflow/traces/${traceId}

instead of

http://localhost:8080/ajax-api/3.0/mlflow/traces/${traceId}

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests
Screen.Recording.2025-11-25.at.13.22.02.mov

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Trace Assessments can now be edited in the UI, when MLflow is served behind a reverse proxy on a subpath

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

@kbolashev Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. labels Nov 25, 2025
…not absolute

Signed-off-by: Kirill Bolashev <kirill@dagshub.com>
@kbolashev kbolashev force-pushed the assessments-reverse-proxy branch from 8d5b525 to dd0f26a Compare November 25, 2025 11:28
@kbolashev
Copy link
Contributor Author

Amended the commit, adding the sign off.


export const deleteAssessment = ({ traceId, assessmentId }: { traceId: string; assessmentId: string }) =>
fetchAPI(`/ajax-api/3.0/mlflow/traces/${traceId}/assessments/${assessmentId}`, 'DELETE');
fetchAPI(`ajax-api/3.0/mlflow/traces/${traceId}/assessments/${assessmentId}`, 'DELETE');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this! can you wrap the relative URL in getAjaxUrl? it's already imported in the file we just missed calling it. i will create a lint rule to hopefully prevent this from happening in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, didn't notice that. Thanks for letting me know and thanks for fixing it 😄

@daniellok-db daniellok-db self-assigned this Nov 26, 2025
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Documentation preview for 70a7977 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@serena-ruan serena-ruan added this pull request to the merge queue Nov 27, 2025
Merged via the queue into mlflow:master with commit 6258099 Nov 27, 2025
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants