UI: Request TraceInfo and Trace Assessments from a relative API path #19032
Merged
serena-ruan merged 2 commits intomlflow:masterfrom Nov 27, 2025
Merged
UI: Request TraceInfo and Trace Assessments from a relative API path #19032serena-ruan merged 2 commits intomlflow:masterfrom
serena-ruan merged 2 commits intomlflow:masterfrom
Conversation
Contributor
|
@kbolashev Thank you for the contribution! Could you fix the following issue(s)? ⚠ DCO checkThe DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details. |
…not absolute Signed-off-by: Kirill Bolashev <kirill@dagshub.com>
8d5b525 to
dd0f26a
Compare
Contributor
Author
|
Amended the commit, adding the sign off. |
|
|
||
| export const deleteAssessment = ({ traceId, assessmentId }: { traceId: string; assessmentId: string }) => | ||
| fetchAPI(`/ajax-api/3.0/mlflow/traces/${traceId}/assessments/${assessmentId}`, 'DELETE'); | ||
| fetchAPI(`ajax-api/3.0/mlflow/traces/${traceId}/assessments/${assessmentId}`, 'DELETE'); |
Collaborator
There was a problem hiding this comment.
thanks for catching this! can you wrap the relative URL in getAjaxUrl? it's already imported in the file we just missed calling it. i will create a lint rule to hopefully prevent this from happening in the future.
Contributor
Author
There was a problem hiding this comment.
oh, didn't notice that. Thanks for letting me know and thanks for fixing it 😄
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Contributor
|
Documentation preview for 70a7977 is available at: More info
|
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#19031
What changes are proposed in this pull request?
Change API calls happening in
mlflow/server/js/src/shared/web-shared/model-trace-explorer/api.tsto happen from relative path, and not absolute.This way, if MLflow is being proxied under
http://localhost:8080/mlflow, the call to e.g. get the trace info gets fired to:instead of
How is this PR tested?
Screen.Recording.2025-11-25.at.13.22.02.mov
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Trace Assessments can now be edited in the UI, when MLflow is served behind a reverse proxy on a subpath
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.