Skip to content

Add FURB148 linting rule and fix unnecessary enumerate usage#19028

Merged
harupy merged 2 commits intomasterfrom
copilot/add-furb148-rule
Nov 25, 2025
Merged

Add FURB148 linting rule and fix unnecessary enumerate usage#19028
harupy merged 2 commits intomasterfrom
copilot/add-furb148-rule

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Adds the FURB148 (unnecessary-enumerate) rule from refurb to detect cases where enumerate() is used but either the index or value is discarded.

Changes:

  • Added FURB148 to pyproject.toml lint rules
  • Fixed 4 violations by replacing enumerate() with direct iteration where only values were used:
    • examples/pytorch/HPOExample/hpo_mnist.py - training loop iteration
    • mlflow/utils/proto_json_utils.py - protobuf list value construction
    • tests/genai/datasets/test_fluent.py - trace ID iteration
    • tests/store/tracking/test_sqlalchemy_store.py - configuration iteration

The rule enforces cleaner iteration patterns: use for item in items when only values are needed, or for i in range(len(items)) when only indices are needed.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Add FURB148 in pyproject.toml. Run ruff rule FURB148 to understand the rule. Once added, run ruff check and fix violations


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@harupy harupy marked this pull request as ready for review November 25, 2025 09:22
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add FURB148 rule to pyproject.toml Add FURB148 linting rule and fix unnecessary enumerate usage Nov 25, 2025
Copilot AI requested a review from harupy November 25, 2025 09:32
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 25, 2025
@harupy harupy enabled auto-merge November 25, 2025 09:38
@harupy harupy disabled auto-merge November 25, 2025 10:26
@harupy harupy merged commit fa45fdd into master Nov 25, 2025
47 of 51 checks passed
@harupy harupy deleted the copilot/add-furb148-rule branch November 25, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants