Skip to content

Extend os_environ_delete_in_test clint rule to detect os.environ.pop()#19027

Merged
harupy merged 3 commits intomasterfrom
copilot/extend-os-environ-delete-test
Nov 25, 2025
Merged

Extend os_environ_delete_in_test clint rule to detect os.environ.pop()#19027
harupy merged 3 commits intomasterfrom
copilot/extend-os-environ-delete-test

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Extended the os_environ_delete_in_test clint rule to detect os.environ.pop() in addition to del os.environ[...].

Changes:

  • Modified OsEnvironDeleteInTest.check() to accept both ast.Delete and ast.Call nodes
  • Added os.environ.pop() detection using resolver.resolve(node) == ["os", "environ", "pop"]
  • Updated linter's visit_Call() to invoke the rule check
  • Updated error message to reflect both patterns
  • Added tests for pop() detection with and without default values

Example:

# Both patterns are now flagged in test files
def test_something():
    del os.environ["VAR"]           # Already detected
    os.environ.pop("VAR")           # Now detected
    os.environ.pop("VAR", None)     # Now detected

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Extend dev/clint/src/clint/rules/os_environ_delete_in_test.py to cover os.environ.pop(...)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@harupy harupy marked this pull request as ready for review November 25, 2025 09:22
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Copilot AI and others added 2 commits November 25, 2025 09:31
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Extend tests for os.environ.pop in os_environ_delete_in_test Extend os_environ_delete_in_test clint rule to detect os.environ.pop() Nov 25, 2025
Copilot AI requested a review from harupy November 25, 2025 09:37
@harupy harupy changed the title Extend os_environ_delete_in_test clint rule to detect os.environ.pop() Extend os_environ_delete_in_test clint rule to detect os.environ.pop() Nov 25, 2025
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 25, 2025
@harupy harupy changed the title Extend os_environ_delete_in_test clint rule to detect os.environ.pop() Extend os_environ_delete_in_test clint rule to detect os.environ.pop() Nov 25, 2025
@harupy harupy enabled auto-merge November 25, 2025 09:44
@harupy harupy disabled auto-merge November 25, 2025 12:05
@harupy harupy merged commit 8089a01 into master Nov 25, 2025
56 of 79 checks passed
@harupy harupy deleted the copilot/extend-os-environ-delete-test branch November 25, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants