Skip to content

Add support for SGC run resumption from Databricks Jobs#19015

Merged
artjen merged 13 commits intomlflow:masterfrom
artjen:sgcRunResume
Nov 26, 2025
Merged

Add support for SGC run resumption from Databricks Jobs#19015
artjen merged 13 commits intomlflow:masterfrom
artjen:sgcRunResume

Conversation

@artjen
Copy link
Collaborator

@artjen artjen commented Nov 24, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19015/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19015/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19015/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Automatically associate a Databricks jobId with a MLflow run_id when specifying Databricks job parameter SERVERLESS_GPU_COMPUTE_ASSOCIATED_JOB_RUN_ID. This allows MLflow runs to be resumed across Databricks Job invocations automatically.

How is this PR tested?

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
@artjen artjen requested a review from harupy November 24, 2025 22:06
@github-actions
Copy link
Contributor

@artjen Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. labels Nov 24, 2025
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Documentation preview for 336d0c0 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
@artjen artjen requested a review from harupy November 25, 2025 02:34
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Comment on lines +549 to +551
client.set_experiment_tag(
exp_id_for_run, sgc_job_run_id_tag_key, active_run_obj.info.run_id
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Databricks, maximum allowed tags per experiment is limited 1000. Could this be an issue?

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users have to specify the SERVERLESS_GPU_COMPUTE_ASSOCIATED_JOB_RUN_ID parameter in the running job to take effect:

    try:
        return dbutils.jobs.taskValues.get(
            "SERVERLESS_GPU_COMPUTE_ASSOCIATED_JOB_RUN_ID", debugValue=None
        )
    except Exception as e:
        _logger.debug(f"Failed to retrieve SGC job run ID from task values: {e}", exc_info=True)
        return None

This means that non-SGC users will not add new experiment tags by default.

For SGC users, we can increase the tag limit on a case-by-case basis if this becomes an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
@artjen artjen requested a review from harupy November 25, 2025 18:06
return dbutils.jobs.taskValues.get(
"SERVERLESS_GPU_COMPUTE_ASSOCIATED_JOB_RUN_ID", debugValue=None
)
except Exception as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non blocker] is it possible to have more specific exceptions here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to ensure this will not disrupt the normal start_run flow. The error is reprinted in a debug message below for debugging if necessary.

Copy link
Contributor

@XiaohanZhangCMU XiaohanZhangCMU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks looks nice! left two nits.

Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artjen artjen added this pull request to the merge queue Nov 26, 2025
Merged via the queue into mlflow:master with commit f08459e Nov 26, 2025
48 of 50 checks passed
@artjen artjen deleted the sgcRunResume branch November 26, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants