Skip to content

Enable FURB129 (readlines-in-for) rule#18983

Merged
harupy merged 3 commits intomasterfrom
copilot/enable-readlines-in-for-rule
Nov 24, 2025
Merged

Enable FURB129 (readlines-in-for) rule#18983
harupy merged 3 commits intomasterfrom
copilot/enable-readlines-in-for-rule

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18983/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18983/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18983/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Enable ruff's FURB129 rule which enforces iterating directly over file objects instead of calling .readlines(). This is more performant (avoids loading entire file into memory) and idiomatic.

Changes:

  • Added FURB129 to ruff configuration in pyproject.toml
  • Fixed 2 violations: replaced f.readlines() with f in file iteration
# Before
for line in f.readlines():
    ...

# After
for line in f:
    ...

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Enable readlines-in-for (FURB129). Run ruff rule to see what this rule enforce. Once enabled, run ruff check and fis violations


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable readlines-in-for rule in codebase Enable FURB129 (readlines-in-for) rule Nov 24, 2025
Copilot AI requested a review from harupy November 24, 2025 01:28
@harupy harupy marked this pull request as ready for review November 24, 2025 01:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Documentation preview for dfc241e is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@harupy harupy added the rn/none List under Small Changes in Changelogs. label Nov 24, 2025
@github-actions github-actions bot added the area/build Build and test infrastructure for MLflow label Nov 24, 2025
@harupy harupy enabled auto-merge November 24, 2025 05:23
@harupy harupy added this pull request to the merge queue Nov 24, 2025
Merged via the queue into master with commit d789b24 Nov 24, 2025
48 checks passed
@harupy harupy deleted the copilot/enable-readlines-in-for-rule branch November 24, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants