Skip to content

Fix bug in chat sessions view where new sessions created after UI launch are not visible due to incorrect timestamp filtering#18928

Merged
dbczumar merged 3 commits intomlflow:masterfrom
dbczumar:date_fix
Nov 24, 2025
Merged

Fix bug in chat sessions view where new sessions created after UI launch are not visible due to incorrect timestamp filtering#18928
dbczumar merged 3 commits intomlflow:masterfrom
dbczumar:date_fix

Conversation

@dbczumar
Copy link
Collaborator

@dbczumar dbczumar commented Nov 19, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18928/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18928/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18928/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Fix bug in chat sessions view where new sessions created after UI launch are not visible due to incorrect timestamp filtering

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

*Before

{locations: [{type: "MLFLOW_EXPERIMENT", mlflow_experiment: {experiment_id: "1"}}],…}
filter
: 
"attributes.timestamp_ms > 1762987653712 AND attributes.timestamp_ms < 1763592453712 AND request_metadata.mlflow.trace.session ILIKE '%%'"
locations
: 
[{type: "MLFLOW_EXPERIMENT", mlflow_experiment: {experiment_id: "1"}}]
max_results
: 
500
Screenshot 2025-11-19 at 2 48 53 PM

After

Sessions show up because timestamp filter is correct:

{locations: [{type: "MLFLOW_EXPERIMENT", mlflow_experiment: {experiment_id: "1"}}],…}
filter
: 
"attributes.timestamp_ms > 1762987653712 AND attributes.timestamp_ms < 1763592609398 AND request_metadata.mlflow.trace.session ILIKE '%%'"
locations
: 
[{type: "MLFLOW_EXPERIMENT", mlflow_experiment: {experiment_id: "1"}}]
max_results
: 
500
Screenshot 2025-11-19 at 2 50 43 PM

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Fix bug causing newly-created chat sessions to be hidden from the UI

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: dbczumar <corey.zumar@databricks.com>
The sessions tab was using a different timestamp threshold compared
to the traces tab when making network requests. This was caused by
the sessions page missing the MonitoringConfigProvider wrapper.

Root cause:
- TracesV3View wraps its implementation with MonitoringConfigProvider
- ExperimentChatSessionsPage was missing this wrapper
- Without the provider, useMonitoringConfig falls back to a default
  config with a different dateNow value, causing timestamp calculations
  to differ between the two tabs

Fix:
- Added MonitoringConfigProvider wrapper to ExperimentChatSessionsPage
- Now both tabs use the same monitoring context and dateNow value
- This ensures consistent timestamp filtering across both tabs

The fix follows the exact same pattern as TracesV3View for consistency.

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
@github-actions github-actions bot added v3.6.1 area/tracing MLflow Tracing and its integrations rn/bug-fix Mention under Bug Fixes in Changelogs. labels Nov 19, 2025
@github-actions
Copy link
Contributor

Documentation preview for 74a27b2 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,6 +1,5 @@
import { ErrorBoundary } from 'react-error-boundary';
import { ExperimentChatSessionsGenericErrorState } from './ExperimentChatSessionsGenericErrorState';
import { MonitoringConfigProvider } from '../../hooks/useMonitoringConfig';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it looks like this is used in the edge blocked version upstream, but i missed putting it in the OSS version. thanks for the catch!

@dbczumar dbczumar merged commit ecf6cb9 into mlflow:master Nov 24, 2025
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing MLflow Tracing and its integrations rn/bug-fix Mention under Bug Fixes in Changelogs. v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants