Skip to content

Fix scorers issue on Strands traces#18835

Merged
B-Step62 merged 8 commits intomlflow:masterfrom
joelrobin18:fix_18796
Dec 12, 2025
Merged

Fix scorers issue on Strands traces#18835
B-Step62 merged 8 commits intomlflow:masterfrom
joelrobin18:fix_18796

Conversation

@joelrobin18
Copy link
Collaborator

@joelrobin18 joelrobin18 commented Nov 13, 2025 •
edited by github-actions bot
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18835/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18835/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18835/merge

Related Issues/PRs

Fix #18796

What changes are proposed in this pull request?

Fix scorers issue when using Strands traces using autotracing

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fix scorers issue when using Strands traces using autotracing

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@joelrobin18
Fix scorers issue on Strands traces
f3eca75 
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
@github-actions github-actions bot added area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/bug-fix Mention under Bug Fixes in Changelogs. labels Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

Documentation preview for b4471b1 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@joelrobin18
lint fix
94e5b63 
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
@joelrobin18
Merge branch 'master' into fix_18796
6ff1f46
@B-Step62 B-Step62 self-requested a review November 19, 2025 00:52
@B-Step62 B-Step62 self-assigned this Nov 19, 2025
B-Step62
B-Step62 reviewed Nov 19, 2025
View reviewed changes
mlflow/genai/judges/prompts/correctness.py Outdated
response: str,
expected_response: str | None = None,
expected_facts: list[str] | None = None,
expected_facts: str | list[str] | None = None,
Copy link
Collaborator

@B-Step62 B-Step62 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the change? (It looks like not?)

mlflow/genai/utils/trace_utils.py Outdated
if isinstance(value, str):
return value

# Handle list of messages directly (e.g., from Strands)
Copy link
Collaborator

@B-Step62 B-Step62 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelrobin18 This logic certainly works, but one context I should've shared is we generally try to remove this type of custojm parsing. LLMs are generally good enough to handle the full messages not just a content string. In general no parsing is easier to reaon about from user perspective. Ideally we also want to remove L302-207, but it's breaking change so we kept them.

I think we can simply has isinstance(dict) check at L302 and let strands messages fallback to str(value)

Copy link

@rahuljungbahadur rahuljungbahadur Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Please let me know if I can help contribute to this issue. I had originally raised it and it is blocking me in adopting MLFlow in my team.

B-Step62
B-Step62 reviewed Dec 12, 2025
View reviewed changes
B-Step62
B-Step62 reviewed Dec 12, 2025
View reviewed changes
@B-Step62
revert extra changes
e8f9b6d 
Signed-off-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
B-Step62
B-Step62 reviewed Dec 12, 2025
View reviewed changes
@B-Step62
Apply suggestions from code review
74ab9e8 
Signed-off-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
B-Step62
B-Step62 reviewed Dec 12, 2025
View reviewed changes
@B-Step62
Update mlflow/genai/utils/trace_utils.py
680f782 
Signed-off-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
B-Step62
B-Step62 reviewed Dec 12, 2025
View reviewed changes
@B-Step62
fix test
b4471b1 
Signed-off-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
@B-Step62 B-Step62 added this pull request to the merge queue Dec 12, 2025
Merged via the queue into mlflow:master with commit 0ded046 Dec 12, 2025
66 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B-Step62 B-Step62 B-Step62 approved these changes

+1 more reviewer

@rahuljungbahadur rahuljungbahadur rahuljungbahadur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@B-Step62 B-Step62

Labels

area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/bug-fix Mention under Bug Fixes in Changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to run mlflow.genai.scorers on Strands traces logged using autolog

3 participants

@joelrobin18 @rahuljungbahadur @B-Step62