Skip to content

Add missing _delete_trace_tag_v3 api#18813

Merged
B-Step62 merged 6 commits intomlflow:masterfrom
Tian-Sky-Lan:tlan/18721-delete_trace_tag_api_bug
Nov 26, 2025
Merged

Add missing _delete_trace_tag_v3 api#18813
B-Step62 merged 6 commits intomlflow:masterfrom
Tian-Sky-Lan:tlan/18721-delete_trace_tag_api_bug

Conversation

@Tian-Sky-Lan
Copy link
Contributor

@Tian-Sky-Lan Tian-Sky-Lan commented Nov 12, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18813/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18813/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18813/merge

Related Issues/PRs

Resolve #18721

What changes are proposed in this pull request?

  1. Add the missing _delete_trace_tag_v3 handler for Flask router, to be consistent with _set_trace_tag_v3.
  2. Changed the frontend's DELETE request for delete trace tag from using url to body.
  3. 6 new unit tests to make sure flask route to the correct handler for delete_trace_tag and set_trace_tag for both v2 and v3 version

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests
Screen.Recording.2025-11-09.at.10.29.32.PM.mp4

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fix the bug of unable to delete the trace tags. User may experience HTTP 400 bug when trying to delete the trace tags previously.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

Yes

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@Tian-Sky-Lan Tian-Sky-Lan force-pushed the tlan/18721-delete_trace_tag_api_bug branch from ddf7f04 to a642017 Compare November 12, 2025 21:34
@Tian-Sky-Lan Tian-Sky-Lan marked this pull request as ready for review November 12, 2025 21:34
@Tian-Sky-Lan
Copy link
Contributor Author

Hi team, may I get some eyes on this one? it is resolving an api issue from our community. Also I am a new developer for this project, please let me know if my workflow / code needs more work here, thansk! @B-Step62 @serena-ruan @harupy

Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good overall, can you fix the conflict and address nit comments? Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Documentation preview for 9b49e05 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@Tian-Sky-Lan Tian-Sky-Lan force-pushed the tlan/18721-delete_trace_tag_api_bug branch 2 times, most recently from a472de8 to aabfcc8 Compare November 24, 2025 04:18
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
@Tian-Sky-Lan Tian-Sky-Lan force-pushed the tlan/18721-delete_trace_tag_api_bug branch 2 times, most recently from 299b0cd to 35cd6f0 Compare November 24, 2025 04:41
@Tian-Sky-Lan
Copy link
Contributor Author

Hi @B-Step62 , feel free to take another look of this one, already resolved your last comment and resolved conlicts. ( I believe there are some workflows can only be triggered after your approval.

@B-Step62
Copy link
Collaborator

@Tian-Sky-Lan Can you fix the linter issues? https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#manual-python-development-environment-configuration

@github-actions github-actions bot added area/tracing MLflow Tracing and its integrations area/tracking Tracking service, tracking client APIs, autologging area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. labels Nov 25, 2025
@github-actions
Copy link
Contributor

Validation Failed: This workflow can only be triggered by a repository owner, member, or collaborator. @Tian-Sky-Lan (NONE) does not have sufficient permissions.

@github-actions
Copy link
Contributor

Validation Failed: This workflow can only be triggered on PRs filed by a repository owner, member, or collaborator. @Tian-Sky-Lan (NONE) does not have sufficient permissions.

@Tian-Sky-Lan
Copy link
Contributor Author

Tian-Sky-Lan commented Nov 25, 2025

image @B-Step62 Hi I pushed a new commit, and it passed (on my fork repo) all previous failed checks like protos, lint and patch notes, please take a look, thanks!

@Tian-Sky-Lan
Copy link
Contributor Author

Hi @B-Step62 , I found that all the checks passed (yeah), but I didn't see a merge button there but only a update branch, could you trigger the checks for me? Sorry this one is a back and forth effort.

@B-Step62 B-Step62 added this pull request to the merge queue Nov 26, 2025
@B-Step62
Copy link
Collaborator

@Tian-Sky-Lan No problem, just merged the PR. Thank you so much for the contribution!

Merged via the queue into mlflow:master with commit ef5ebd5 Nov 26, 2025
79 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing MLflow Tracing and its integrations area/tracking Tracking service, tracking client APIs, autologging area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot remove Trace Tags from the UI

2 participants