Merged
Conversation
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
Contributor
|
Documentation preview for fd2251b is available at: More info
|
… trace_comparison
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
6d8c630 to
7d2463c
Compare
B-Step62
reviewed
Sep 28, 2025
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableActions.tsx
Outdated
Show resolved
Hide resolved
.../server/js/src/shared/web-shared/genai-traces-table/components/GenAITraceComparisonModal.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| if (isInComparisonView) { |
Collaborator
There was a problem hiding this comment.
@joelrobin18 @daniellok-db I want to re-iterate the decision of showing summary view only, because since 3.3 we show metadata like trace id, latency, token counts, outside the summary view.
I think these are important information for trace comparison. Then wondering if it is technically challenging to simply render the entire UI including this header and tree in the comparison view? It is probably more robust to changes like this.
Collaborator
There was a problem hiding this comment.
cc @joelrobin18 i think this is almost there but a few things (see video for reference):
- both sides should scroll together so comparison is easy when the traces are similar
- assessments should render above the tabs, and the header above assessments (we probably want to make a new component like
ModelTraceExplorerComparisonLayoutor something so we can rearrange the stuff) - let's hide the assessment toggle everywhere if we're in the comparison view, and simply render a chevron to expand / collapse the assessments panel
LMK if you don't have time to address and I can simply push some updates to this PR. thanks for all the work so far on this!
Screen.Recording.2025-10-15.at.11.44.27.AM.mov
mlflow/server/js/src/experiment-tracking/components/evaluations/RunViewEvaluationsTab.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableActions.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableActions.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableActions.tsx
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableActions.tsx
Outdated
Show resolved
Hide resolved
.../server/js/src/shared/web-shared/genai-traces-table/components/GenAITraceComparisonModal.tsx
Outdated
Show resolved
Hide resolved
.../server/js/src/shared/web-shared/genai-traces-table/components/GenAITraceComparisonModal.tsx
Outdated
Show resolved
Hide resolved
.../server/js/src/shared/web-shared/genai-traces-table/components/GenAITraceComparisonModal.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/genai-traces-table/types.ts
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorer.tsx
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorer.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorer.tsx
Outdated
Show resolved
Hide resolved
.../server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerComparisonLayout.tsx
Outdated
Show resolved
Hide resolved
...rver/js/src/shared/web-shared/model-trace-explorer/assessments-pane/AssessmentPaneToggle.tsx
Show resolved
Hide resolved
...ow/server/js/src/shared/web-shared/model-trace-explorer/assessments-pane/AssessmentsPane.tsx
Outdated
Show resolved
Hide resolved
...ow/server/js/src/shared/web-shared/model-trace-explorer/assessments-pane/AssessmentsPane.tsx
Show resolved
Hide resolved
0d3df50 to
c8d7225
Compare
Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>
c8d7225 to
4616ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Fix #16711
What changes are proposed in this pull request?
Compare button for trace comparison
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Compare different traces
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.