Skip to content

Support reading model registry URI from spark conf#10556

Merged
smurching merged 4 commits intomlflow:masterfrom
smurching:smurching/model-registry-uri-spark-conf
Nov 30, 2023
Merged

Support reading model registry URI from spark conf#10556
smurching merged 4 commits intomlflow:masterfrom
smurching:smurching/model-registry-uri-spark-conf

Conversation

@smurching
Copy link
Collaborator

@smurching smurching commented Nov 30, 2023

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10556/merge

Checkout with GitHub CLI

gh pr checkout 10556

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Support reading model registry URI from spark conf, to allow for easier configuration in environments where setting environment variables is difficult.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Sid Murching <sid.murching@databricks.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023

Documentation preview for 475bb52 will be available here when this CircleCI job completes successfully.

More info

Signed-off-by: Sid Murching <sid.murching@databricks.com>
Copy link
Collaborator

@jerrylian-db jerrylian-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Before landing can you do a manual test of this change that shows that the Spark conf is capable of setting the registry URI in a Databricks cluster?

Co-authored-by: Jerry Liang <66143562+jerrylian-db@users.noreply.github.com>
Signed-off-by: Siddharth Murching <smurching@gmail.com>
@smurching
Copy link
Collaborator Author

Thanks @jerrylian-db ! I did the manual test, I'll rerun it with the latest changes to make sure it still works before merging

…e if set

Signed-off-by: Sid Murching <sid.murching@databricks.com>
@smurching smurching added the rn/none List under Small Changes in Changelogs. label Nov 30, 2023
@smurching smurching merged commit 437b5cf into mlflow:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants