Skip to content

Conversation

@priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Apr 8, 2024

The internal target setting configurations had a bug where the variants all used post-layernorm.
We reran the target setting procedure with corrected configurations.
These updated targets are the minimum BLEU score values of:

  1. the previously checked in targets
  2. the targets as determined by the full target setting procedure on internal experiments with corrected configs.
  3. the best eval metrics achieved with the GitHub code with the updated hparam point from the target setting procedure.

These updates result in slightly easier targets than previously checked in tarets.

@github-actions
Copy link

github-actions bot commented Apr 8, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg marked this pull request as ready for review April 8, 2024 19:41
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner April 8, 2024 19:41
@priyakasimbeg priyakasimbeg merged commit f463c1d into dev Apr 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
@priyakasimbeg priyakasimbeg deleted the wmt_variant_targets_fix branch December 21, 2024 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants