Add hook for Modules that need finer grained control on validating missing parameters#336
Merged
davidkoski merged 2 commits intomainfrom Jan 22, 2026
Merged
Add hook for Modules that need finer grained control on validating missing parameters#336davidkoski merged 2 commits intomainfrom
davidkoski merged 2 commits intomainfrom
Conversation
…ssing parameters - if validation includes .allModelKeysSet then a missing non-optional parameter will throw a validation error - modules have no clean way to fine tune this, e.g. if one particular parameter is ok to be missing - would allow a fix for ml-explore/mlx-swift-lm#50
Collaborator
Author
|
@ronaldmannak FYI |
davidkoski
commented
Jan 15, 2026
| open func updateMissing( | ||
| parameter: String, verify: VerifyUpdate, path: [String], modulePath: [String] | ||
| ) throws { | ||
| throw UpdateError.keyNotFound(path: path, modules: modulePath) |
Collaborator
Author
There was a problem hiding this comment.
So for example if "x" was ok to be missing this could check parameter == "x" and simply return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Specifically this adds a method that can be overridden in subclasses to customize the behavior.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes