Merged
Conversation
Collaborator
Author
|
FYI @incertum |
davidkoski
commented
Jan 8, 2026
| name: Build and Test | ||
|
|
||
| on: pull_request | ||
| on: pull_request |
Collaborator
Author
There was a problem hiding this comment.
It looks like the editor I used decided to tidy this up
davidkoski
commented
Jan 8, 2026
|
|
||
| linux_build_cmake_container: | ||
| name: Linux Container CMake Swift Build (${{ matrix.container }} ${{ matrix.arch }}) | ||
| needs: lint |
Collaborator
Author
There was a problem hiding this comment.
This is the only real change -- make this wait for the lint step.
Collaborator
Author
There was a problem hiding this comment.
Note linux_build_cmake_cuda already had this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The linux cmake builds were missing a depend on
lintChecklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes