thread safety -- hold lock while calling stream sync#323
Merged
davidkoski merged 1 commit intomainfrom Dec 18, 2025
Merged
Conversation
davidkoski
commented
Dec 18, 2025
| mlx_synchronize(ctx) | ||
| _ = evalLock.withLock { | ||
| mlx_synchronize(ctx) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is the same pattern we use for all calls into the mlx runtime.
awni
approved these changes
Dec 18, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Looks good.. some day MLX will be thread safe 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Observed: stream synchronization is not thread safe in roughly the same way that eval is not (if this were to be called while asyncEval was running it can manipulate the same global state in the command encoders). Hold the eval lock while calling.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes