new[CMake, CI]: add CUDA GPU backend to Linux CMake Swift build option.#320
Conversation
Signed-off-by: Melissa Kilby <mkilby@apple.com>
Signed-off-by: Melissa Kilby <mkilby@apple.com>
Signed-off-by: Melissa Kilby <mkilby@apple.com>
| mkdir -p build | ||
| pushd build | ||
| cmake -DMLX_BUILD_METAL=OFF -DMLX_BUILD_CUDA=ON -DMLX_C_BUILD_EXAMPLES=OFF .. -G Ninja | ||
| ninja |
There was a problem hiding this comment.
can this run the swift tests? there might be one or two metal specific ones that we have to exclude
There was a problem hiding this comment.
I think only MLXFastKernelTests.swift won't run on CUDA. Maybe that should be renamed to have Metal in the name as it is Metal specific. There is additional API that we can build to do custom CUDA kernels along the same lines, but we can add that later.
|
Excellent! Thanks for the mention, looking very forward to this. |
davidkoski
left a comment
There was a problem hiding this comment.
Changes look good!
I think we should run the unit tests but that can be added as a follow-on.
Great point re unit tests for the next PR. I can take a look shortly, but let's do it in a new PR. |
Signed-off-by: Melissa Kilby <mkilby@apple.com>
c3d984a to
f173d56
Compare
Proposed changes
@davidkoski kindly asking for a review, thanks a bunch in advance!
CC @madrob @Joannis
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes