fix #315 -- do not reshape during SDPA#316
Merged
davidkoski merged 1 commit intomainfrom Dec 15, 2025
Merged
Conversation
- this was changed on the python side in ml-explore/mlx@16546c7 - in v0.29.1 this still produced the correct result but in v0.30.0 it does not - in particular a different specialized function is used
davidkoski
commented
Dec 15, 2025
| public func callAsFunction(_ x: MLXArray, offset: Int) -> MLXArray { | ||
| let shape = x.shape | ||
| var x = x.reshaped(-1, x.dim(-2), x.dim(-1)) | ||
| x = MLXFast.RoPE( |
Collaborator
Author
There was a problem hiding this comment.
Adopt ml-explore/mlx@16546c7 (fro Mar 18, 2024!!!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was changed on the python side in ml-explore/mlx@16546c7
in v0.29.1 this still produced the correct result but in v0.30.0 it does not
[BUG] MLXVLM generates only 1 token. #315
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes