add .arrays back to ScaledDotProductAttentionMaskMode#314
Merged
davidkoski merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
- ml-explore/mlx-swift-lm#17 - no longer supported, but we can deprecate and add a runtime check - keeps source compatibility -- this would have otherwise been tricky to support
davidkoski
commented
Dec 9, 2025
| case array(MLXArray) | ||
|
|
||
| @available(*, deprecated, message: "Use .array instead") | ||
| case arrays([MLXArray]) |
Collaborator
Author
There was a problem hiding this comment.
Without this downstream (e.g. mlx-swift-lm) could have been compatible with old OR new mlx-swift, but not both.
Collaborator
Author
There was a problem hiding this comment.
The mlx-c / C++ layer removed the ability to pass multiple arrays, but we can still support the API. None of the mlx-swift-lm code used multiple arrays, but switch statements have to handle all the cases.
|
@davidkoski thanks for addressing this issue. Will this change be merged with main? |
Collaborator
Author
|
Merged ut see #309 -- you may need to restrict it to arm64 builds for Release until we have that fixed (vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes