Skip to content

Fix MLXError#308

Merged
davidkoski merged 1 commit intoml-explore:mainfrom
DePasqualeOrg:fix-error
Dec 2, 2025
Merged

Fix MLXError#308
davidkoski merged 1 commit intoml-explore:mainfrom
DePasqualeOrg:fix-error

Conversation

@DePasqualeOrg
Copy link
Contributor

Proposed changes

MLXError should conform to LocalizedError so that error messages can bubble up to consumers of mlx-swift.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@DePasqualeOrg DePasqualeOrg marked this pull request as ready for review December 2, 2025 15:07
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@davidkoski davidkoski merged commit 3d225a8 into ml-explore:main Dec 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants