Skip to content

update to mlx 0.30.0#299

Merged
davidkoski merged 9 commits intomainfrom
mlx-v0.29.4
Dec 1, 2025
Merged

update to mlx 0.30.0#299
davidkoski merged 9 commits intomainfrom
mlx-v0.29.4

Conversation

@davidkoski
Copy link
Collaborator

@davidkoski davidkoski commented Nov 18, 2025 •
edited
Loading

Proposed changes

update to mlx 0.30.0

  • add median
  • quantization parameters now optional

Note: this does NOT enable NAX -- that requires building shaders with -std=metal4.0 and we don't have control over that. Solutions being investigated.

@davidkoski
Copy link
Collaborator Author

davidkoski commented Nov 18, 2025

@incertum FYI

@davidkoski davidkoski requested a review from awni November 18, 2025 23:25
@incertum
Copy link
Contributor

incertum commented Nov 20, 2025

@incertum FYI

Excellent @davidkoski -- thanks for already starting this.
At this point, we are waiting on the mlx-c bump in order to finalize this PR?

@davidkoski
Copy link
Collaborator Author

davidkoski commented Nov 20, 2025

@incertum FYI

Excellent @davidkoski -- thanks for already starting this. At this point, we are waiting on the mlx-c bump in order to finalize this PR?

I think that is ready. We will use mlx v0.30.0. This should be usable for most purposes but I can't merge it until I can verify that the NAX pieces work.

@davidkoski
Copy link
Collaborator Author

davidkoski commented Nov 20, 2025

(and I need to update the tags we point to)

@davidkoski
Copy link
Collaborator Author

davidkoski commented Nov 20, 2025

ok, mlx-c and mlx are up-to-date and build is back to working. I think the CMakeList at the top level needs to be updated to the mlx-c branch if you want to use that (I usually do this last once the mlx-c tag is cut).

@davidkoski davidkoski changed the title update to mlx 0.29.4 (or later) update to mlx 0.30.0 Dec 1, 2025
awni
awni reviewed Dec 1, 2025
View reviewed changes
Source/MLX/Ops.swift Outdated
/// - Parameters:
/// - a: the first array
/// - axis: axis to reduce over
/// - keepDims: if `true`keep reduced axis as singleton dimension
Copy link
Member

@awni awni Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - keepDims: if `true`keep reduced axis as singleton dimension
/// - keepDims: if `true` keep reduced axis as singleton dimension

awni
awni reviewed Dec 1, 2025
View reviewed changes
Source/MLX/Ops.swift Outdated
/// - Parameters:
/// - a: the first array
/// - axes: axes to reduce over
/// - keepDims: if `true`keep reduced axis as singleton dimension
Copy link
Member

@awni awni Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - keepDims: if `true`keep reduced axis as singleton dimension
/// - keepDims: if `true` keep reduced axis as singleton dimension

awni
awni reviewed Dec 1, 2025
View reviewed changes
Source/MLX/Ops.swift Outdated
///
/// - Parameters:
/// - a: the first array
/// - keepDims: if `true`keep reduced axis as singleton dimension
Copy link
Member

@awni awni Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - keepDims: if `true`keep reduced axis as singleton dimension
/// - keepDims: if `true` keep reduced axis as singleton dimension

Copy link
Collaborator Author

@davidkoski davidkoski Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, some copy-pasta here -- there are 60 occurrences!

awni
awni approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some nits!

@davidkoski davidkoski merged commit 669c4e6 into main Dec 1, 2025
1 of 2 checks passed
@davidkoski davidkoski deleted the mlx-v0.29.4 branch December 1, 2025 21:38
This was referenced Dec 4, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awni awni awni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidkoski @incertum @awni