Merged
Conversation
davidkoski
reviewed
Jul 7, 2025
Collaborator
|
Also, please run CI is failing because of that. |
Closed
Replace conditional compilation with proper availability check for tvOS 17.0 as suggested in PR review. The architecture property is available on tvOS 17.0 and later according to Apple documentation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
580fc65 to
08bb033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive tvOS support to MLX-Swift by updating the Package.swift manifest and providing architecture compatibility for tvOS devices.
Changes
Problem
MLX-Swift currently doesn't support tvOS, preventing developers from bringing
on-device ML capabilities to Apple TV applications. When attempting to use MLX-Swift
in a tvOS project:
versions
Solution
on tvOS 17.0 and later (as per Apple documentation)
Impact
Testing
Successfully tested on Apple TV (tvOS 18) with a production app:
Use Cases
This enables exciting possibilities for tvOS apps: