add path information for parameter update errors -- great help in debugging#252
Merged
davidkoski merged 4 commits intomainfrom Jul 14, 2025
Merged
add path information for parameter update errors -- great help in debugging#252davidkoski merged 4 commits intomainfrom
davidkoski merged 4 commits intomainfrom
Conversation
Collaborator
Author
|
@DePasqualeOrg FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251
Right now the errors just give the last key and the module that it was being set on. This is hard if e.g. the module is Linear and the model is large -- there are typically a LOT of Linear modules.