Skip to content

if no error handler set produce a fatal error (like the default used to be)#238

Merged
davidkoski merged 1 commit intomainfrom
fatal-default-handler
May 16, 2025
Merged

if no error handler set produce a fatal error (like the default used to be)#238
davidkoski merged 1 commit intomainfrom
fatal-default-handler

Conversation

@davidkoski
Copy link
Collaborator

No description provided.

@davidkoski davidkoski requested a review from awni May 14, 2025 20:07
if let globalHandler {
globalHandler(message, globalData)
} else {
fatalError(message)
Copy link
Collaborator Author

@davidkoski davidkoski May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts the default handling (if you don't arrange for anything) to be back to a fatalError. Without this it would be silent if you also use the per-task error handling.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidkoski davidkoski merged commit d3f89b1 into main May 16, 2025
1 check passed
@davidkoski davidkoski deleted the fatal-default-handler branch May 16, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants