add saveToData and load from data (safetensors) -- fix #214#218
Merged
davidkoski merged 4 commits intomlx0_24_2from May 1, 2025
Merged
add saveToData and load from data (safetensors) -- fix #214#218davidkoski merged 4 commits intomlx0_24_2from
davidkoski merged 4 commits intomlx0_24_2from
Conversation
davidkoski
commented
Apr 7, 2025
Source/MLX/IO.swift
Outdated
| import Cmlx | ||
| import Foundation | ||
|
|
||
| /// Save array to a binary file in `.npy`format. |
Collaborator
Author
There was a problem hiding this comment.
This first chunk is just moving related methods from Ops.swift
davidkoski
commented
Apr 7, 2025
| } | ||
| } | ||
|
|
||
| // MARK: - Memory I/O |
Collaborator
Author
There was a problem hiding this comment.
b794816 to
0fbdb99
Compare
awni
reviewed
Apr 28, 2025
Source/MLX/IO.swift
Outdated
| /// Save dictionary of arrays in `safetensors` format into `Data`. | ||
| /// | ||
| /// - Parameters: | ||
| /// - a: array to save |
Member
There was a problem hiding this comment.
Nit: incorrectly labeled should be arrays
awni
reviewed
Apr 28, 2025
Source/MLX/IO.swift
Outdated
| /// - Parameters: | ||
| /// - a: array to save | ||
| /// - metadata: metadata to save | ||
| /// - stream: stream or device to evaluate on |
Member
There was a problem hiding this comment.
Am I missing something or is the stream unused?
Collaborator
Author
There was a problem hiding this comment.
You are correct -- the load produces something that goes on a stream, not the save
Member
|
Just left a couple comments, please take a look and merge when ready. |
3f43d6e to
a0c5138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves and loads from memory: