Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mkdocstrings/python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.7.2
Choose a base ref
...
head repository: mkdocstrings/python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.7.3
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 9, 2023

  1. fix: Don't deepcopy the local config 

    This was done in commit 3cbe472
to avoid a type warning that the second and next arguments to ChainMap
are not mutable.
Related Mypy issue: python/typeshed#8430.

When we use `!relative` in MkDocs configuration, the config
then contains a MkDocs path placeholder instance, which itself contains
a reference to the MkDocs config, and all its plugins,
including mkdocstrings, and all its objects, etc.

Upon deepcopying this huge object tree, deepcopy fails on
mkdocstrings private attribute `_inv_futures`, which contains
`Future` and therefore `thread.RLock` objects, which are not serializable.
This failed with a `TypeError: cannot pickle '_thread.RLock` objects`.

So in this commit we stop deep-copying everything
just to avoid a Mypy warning, and instead we add a type-ignore comment.
If Mypy fixes this someday, we'll simply get a new warning that the
comment is unused.
    @pawamoy
    pawamoy committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1300d2c View commit details
    Browse the repository at this point in the history

  2. chore: Prepare release 1.7.3

    @pawamoy
    pawamoy committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f747ecb View commit details
    Browse the repository at this point in the history
Loading