fix: add timeout to urlopen#820
Merged
pawamoy merged 1 commit intomkdocstrings:mainfrom Apr 15, 2026
Merged
Conversation
This prevents _download_url_with_gz from appearing to be hanging if e.g. the URL is blackholed. Without an explicit timeout, `urlopen.request` uses the global default timeout (`socket.getdefaulttimeout()`), which is `None` by default. This then leaves it up to the OS to decide how long to wait before giving up, which is typically too long for this purpose (e.g. ~127 seconds on Linux).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents _download_url_with_gz from appearing to be hanging if e.g. the URL is blackholed. Without an explicit timeout,
urlopen.requestuses the global default timeout (socket.getdefaulttimeout()), which isNoneby default. This then leaves it up to the OS to decide how long to wait before giving up, which is typically too long for this purpose (e.g. ~127 seconds on Linux).For reviewers
Description of the change
Use an explicit 10 seconds timeout.
Relevant resources
Closes #819