Skip to content

fix: custom_templates config was dropped in previous commit#630

Merged
pawamoy merged 1 commit intomainfrom
fixdrop
Oct 28, 2023
Merged

fix: custom_templates config was dropped in previous commit#630
pawamoy merged 1 commit intomainfrom
fixdrop

Conversation

@oprypin
Copy link
Copy Markdown
Member

@oprypin oprypin commented Oct 28, 2023

No description provided.

Copy link
Copy Markdown
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn implicit tuples!

@pawamoy pawamoy merged commit afc4ea4 into main Oct 28, 2023
@oprypin oprypin deleted the fixdrop branch October 28, 2023 16:17
@oprypin
Copy link
Copy Markdown
Member Author

oprypin commented Oct 28, 2023

Need to switch to ruff format ASAP 😂
it would've formatted as

-    custom_templates = opt.Optional(opt.Dir(exists=True)),
+    custom_templates = (opt.Optional(opt.Dir(exists=True)),)

https://docs.astral.sh/ruff/formatter/black/#single-element-tuples-are-always-parenthesized

@pawamoy
Copy link
Copy Markdown
Member

pawamoy commented Oct 28, 2023

Yeah it has some valuable formatting improvements over Black, I'm OK with using it 🙂
I'll probably test it soon in my project template and apply it everywhere progressively.

@oprypin
Copy link
Copy Markdown
Member Author

oprypin commented Oct 28, 2023

No objections for your projects :)

For myself, I'm just wary about the rollout of the "preview style" of Black which will be something that affects both Black and Ruff as it follows it. And maybe I'll use that opportunity to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants