Skip to content

refactor: Report inventory loading errors#568

Merged
pawamoy merged 2 commits intomasterfrom
report-inventory-error
May 11, 2023
Merged

refactor: Report inventory loading errors#568
pawamoy merged 2 commits intomasterfrom
report-inventory-error

Conversation

@pawamoy
Copy link
Member

@pawamoy pawamoy commented May 11, 2023 •
edited
Loading

Closes #517

@oprypin
Copy link
Member

oprypin commented May 11, 2023

I'll have a few style suggestions, hold up

@oprypin
Copy link
Member

oprypin commented May 11, 2023

Impressive that there is test coverage for this 😊

mkdocstrings/tests/test_inventory.py

Line 38 in e5522af

def test_sphinx_load_mkdocstrings_inventory_file():

@oprypin
Copy link
Member

oprypin commented May 11, 2023

oprypin@0597131 is my style suggestions.

In fact at this point I took out ChainMap, it's just a hinderance and doesn't do anything smart whatsoever.

To apply: git fetch origin $commithash && git merge FETCH_HEAD && git push

@pawamoy
Copy link
Member Author

pawamoy commented May 11, 2023

Thanks, great suggestions!

Impressive that there is test coverage for this blush

Haha yeah 😅? Is this how you found out your edited code didn't work?

@pawamoy
Copy link
Member Author

pawamoy commented May 11, 2023

Suggestions applied 🙂

@oprypin
Copy link
Member

oprypin commented May 11, 2023

Yes :)
Nice

@pawamoy
Copy link
Member Author

pawamoy commented May 11, 2023

Anything else? Care to approve 🙂 ?

@pawamoy pawamoy merged commit 2c05d78 into master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oprypin oprypin oprypin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report URL for HTTP errors

2 participants

@pawamoy @oprypin