fix: correct type signature for BaseCollector.collect#520
Merged
pawamoy merged 1 commit intomkdocstrings:masterfrom Mar 7, 2023
Merged
fix: correct type signature for BaseCollector.collect#520pawamoy merged 1 commit intomkdocstrings:masterfrom
pawamoy merged 1 commit intomkdocstrings:masterfrom
Conversation
This is needed by python library because it needs to pass that argument to a method that declares it as MutableMapping.
Member
|
@ssbarnea should I wait for you to mark this PR as ready for review? |
Contributor
Author
|
@pawamoy No need to wait, if you find the draft PR as good enough, feel free to convert it to -ready-for-review and merge. Thanks for the ping, I forgot, too many changes in too many repos.... |
pawamoy
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed by python library because
collect()needs to pass that argument to a method that declares it as MutableMapping.