fix: add missing space in dictionary comprehension #420
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A space was missing between the value and `for`. For example,
import tempfile
import sys
import griffe
with tempfile.TemporaryDirectory() as tmp:
sys.path.insert(0, tmp)
with open(f"{tmp}/test_for_griffe.py", "x") as f:
print("A = {key: value for key, value in []}", file=f)
module = griffe.load("test_for_griffe")
print(module.get_member("A").value)
displayed:
{key: valuefor (key, value) in []}
Add the missing space.
For more context, see mkdocstrings/python#311
Member
|
Awesome, thanks a lot @niooss-ledger! I just added a test that is expected to fail because for now parentheses are still added around the tuple. I have a fix for that too and will push it once this PR is merged 🙂 |
pawamoy
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
Hello,
A space was missing between the value and
for. For example,Add the missing space.
Relevant resources
I encountered an issue with
mkdocstrings-pythonand reported it in mkdocstrings/python#311 . This Pull Request fixes a part of this issue: with it, random characters no longer appear (because they are used bymkdocstrings-pythonto track cross-references). But there are still rendering issues, due to some code present inmkdocstrings-python(not ingriffe).