Skip to content

fix: Fix loading namespace packages from JSON #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pawamoy merged 13 commits into from
Oct 10, 2025
Merged

fix: Fix loading namespace packages from JSON #413

pawamoy merged 13 commits into from
Oct 10, 2025
+27 −2

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Sep 17, 2025 •
edited
Loading

Closes #407

For reviewers

  • I did not use AI
  • I used AI and thorougly reviewed every code/docs change

I think I'll just remove the section with the checkbox about AI in my future PRs lol

@pawamoy
Copy link
Member

pawamoy commented Sep 17, 2025

I think I'll just remove the section with the checkbox about AI in my future PRs lol

Yes, this privilege has been granted to you many moons ago.

@johnslavik johnslavik force-pushed the b/fix-namespace-packages-from-json branch 6 times, most recently from 6e3b13d to c11704f Compare September 18, 2025 01:42
@pawamoy
Copy link
Member

pawamoy commented Sep 18, 2025

Looking good, just need a small test and we're good to go.

@johnslavik
Copy link
Member Author

johnslavik commented Sep 18, 2025 •
edited
Loading

Yeah, I did 5071560 and c11704f to check for any sensible places near where I could put a test.

@johnslavik johnslavik force-pushed the b/fix-namespace-packages-from-json branch from da9224b to 68c3ab6 Compare September 18, 2025 19:04
@pawamoy pawamoy marked this pull request as ready for review October 10, 2025 16:27
@pawamoy pawamoy merged commit 3cccf27 into main Oct 10, 2025
51 checks passed
@johnslavik johnslavik deleted the b/fix-namespace-packages-from-json branch November 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: from_json seems to be broken

3 participants

@johnslavik @pawamoy